Skip to content

chore: bench public fns with emit repro#23105

Merged
vezenovm merged 4 commits into
merge-train/fairiesfrom
mv/bench-public-fns-with-emit-repro
May 8, 2026
Merged

chore: bench public fns with emit repro#23105
vezenovm merged 4 commits into
merge-train/fairiesfrom
mv/bench-public-fns-with-emit-repro

Conversation

@vezenovm
Copy link
Copy Markdown
Contributor

@vezenovm vezenovm commented May 8, 2026

Adds a bench for the contract shape from AztecProtocol/aztec-nr#35 (15 public fns each emitting an event). No existing bench target covers this flow. I want to see the benefits from follow-up improvements.

@vezenovm vezenovm changed the title feat: bench public fns with emit repro chore: bench public fns with emit repro May 8, 2026
@vezenovm vezenovm requested review from dbanks12, nchamo and nventuro May 8, 2026 18:12
Copy link
Copy Markdown
Contributor

@dbanks12 dbanks12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@vezenovm vezenovm enabled auto-merge (squash) May 8, 2026 18:13
@vezenovm vezenovm added the claudebox Owned by claudebox. it can push to this PR. label May 8, 2026
AztecBot added a commit that referenced this pull request May 8, 2026
vezenovm and others added 3 commits May 8, 2026 19:23
Adds a contract shaped like the public-dispatch repro from
AztecProtocol/aztec-nr#35 (15 public fns each
emitting an event) to the public TX simulator bench and to the contract
expand snapshots. No existing bench targets cover this flow, so changes
to the per-public-fn emit shape are currently invisible on the dashboard.
@AztecBot AztecBot force-pushed the mv/bench-public-fns-with-emit-repro branch from cf8b8ba to 9941a2a Compare May 8, 2026 19:23
@vezenovm vezenovm merged commit c343607 into merge-train/fairies May 8, 2026
14 checks passed
@vezenovm vezenovm deleted the mv/bench-public-fns-with-emit-repro branch May 8, 2026 21:26
AztecBot pushed a commit that referenced this pull request May 8, 2026
Adds a bench for the contract shape from
AztecProtocol/aztec-nr#35 (15 public fns each
emitting an event). No existing bench target covers this flow. I want to
see the benefits from follow-up improvements.
@AztecBot
Copy link
Copy Markdown
Collaborator

AztecBot commented May 8, 2026

✅ Successfully backported to backport-to-v4-next-staging #23080.

github-merge-queue Bot pushed a commit that referenced this pull request May 10, 2026
BEGIN_COMMIT_OVERRIDE
fix: include sqlite binary in its npm package (#23039)
fix: add sendMessagesAs to wallet api schemas (#23041)
refactor(pxe): deduplicate tx hash lookups in MessageContextService
(#23075)
refactor(pxe): batch tagged private log queries across all secrets
(#23048)
refactor(pxe): batch log RPC calls in LogService.fetchLogsByTag (#23088)
feat(pxe,nr): flesh out account stubs and don't exclude syncing for
overrides (#23054)
feat: deploy method refactor 2 (#23033)
feat: fastForwardContractUpdate cheatcode for simulating contract
updates (#22905)
refactor(stdlib): consolidate find-function-by-selector helpers (#23008)
feat(ci): Snapshots for aztec-nr contract compilation failures and nargo
expand (#23061)
chore: kv store test fully on vitest (#23096)
refactor(pxe): skip redundant getBlock RPC when querying at anchor block
(#23100)
chore(playground): bump main chunk size limit 1750 → 1800 KB (#23107)
feat(txe): allow authorizing cross-contract utility calls in nr tests
(#23064)
chore: bench public fns with emit repro (#23105)
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-to-v4-next claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants